Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveModel compatibility between Rails 7 and 8 #4189

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Jan 24, 2025

The internal representation of the validation context has changed between Rails 7 and 8. As we don't use validation contexts, it only has to be ensured that a newly introduced class exists.


CATS has been executed with the following Rails versions:

I.   api with Rails 7 + worker with Rails 8
       -> old job serialization format + new deserialization code
       => No errors

II.  api with Rails 8 + worker with Rails 7
       -> new job serialization format + old deserialization code
       => Errors
         Deserialization for job '<guid>' failed, rescheduling it...
         ... FAILED permanently with Delayed::DeserializationError: Job failed to load: undefined class/module ActiveModel::ValidationContext.

III. api with Rails 8 + worker with Rails 7 + this change
       -> new job serialization format + old deserialization code with compatibility patch
       => No errors
  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

The internal representation of the validation context has changed
between Rails 7 and 8. As we don't use validation contexts, it only has
to be ensured that a newly introduced class exists.
@philippthun philippthun merged commit 4c6c470 into cloudfoundry:main Feb 4, 2025
8 checks passed
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Feb 4, 2025
Changes in cloud_controller_ng:

- ActiveModel compatibility between Rails 7 and 8
    PR: cloudfoundry/cloud_controller_ng#4189
    Author: Philipp Thun <[email protected]>

Dependency updates in cloud_controller_ng:

- build(deps-dev): bump solargraph from 0.51.1 to 0.51.2
    PR: cloudfoundry/cloud_controller_ng#4204
    Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

- build(deps): bump sequel from 5.88.0 to 5.89.0
    PR: cloudfoundry/cloud_controller_ng#4203
    Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants