Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve service plan visibility check (readable orgs) #4217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Feb 13, 2025

When checking for the existence of visible orgs (SELECT 1 AS "one") neither potential duplicates nor the order of entries are important.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

When checking for the visibility of plans in readable orgs (SELECT 1 AS
"one") neither potential duplicates nor the order of entries are
important.
@philippthun philippthun force-pushed the omit-distinct-for-any-query branch from e88dba4 to 584a64a Compare February 13, 2025 15:07
@philippthun philippthun marked this pull request as ready for review February 14, 2025 14:22
Copy link
Contributor

@kathap kathap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants