Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC0030] Updates #1008

Merged
merged 1 commit into from
Oct 29, 2024
Merged

[RFC0030] Updates #1008

merged 1 commit into from
Oct 29, 2024

Conversation

beyhan
Copy link
Member

@beyhan beyhan commented Oct 24, 2024

  • Service Binding name collision behaviour
  • VCAP_SERVICES attribute translation
  • Change ServiceBindingFiles to VolumeMountedFiles to avoid CF terminology leaking into BBS's domain model
  • Files to File, Name to Path and Value to Content for better readability

* Binding name collision behaviour
* `VCAP_SERVICES` attribute translation
@beyhan beyhan requested review from a team, rkoster, stephanme, ameowlia and ChrisMcGowan and removed request for a team October 24, 2024 07:55
@beyhan beyhan added the rfc CFF community RFC label Oct 24, 2024
@beyhan
Copy link
Member Author

beyhan commented Oct 24, 2024

@philippthun, @dimitardimitrov13 could you pls also check on this updates.

@PlamenDoychev
Copy link
Contributor

@dimitardimitrov13, is currently off. Expect update from hiм Monday at the earliest. I'll also take a look.

@dimitardimitrov13
Copy link

Hello, @beyhan, I'm starting the refactoring for all impacted projects: bbs, protobuffers, rep, executor and diego-release.

@stephanme
Copy link
Contributor

@philippthun described the mapping process in details: cloudfoundry/cloud_controller_ng#4036

@beyhan beyhan merged commit 1647fa2 into main Oct 29, 2024
1 check passed
@beyhan beyhan deleted the update-rfc-for-file-based-service-bindings branch October 29, 2024 14:52
@dimitardimitrov13
Copy link

Hello,

All changes requested in this PR have been addressed.
Additionally, if there is anything else to adjust or change, please let us know.

Thank you.
Dimitar

@beyhan
Copy link
Member Author

beyhan commented Oct 31, 2024

Thank you @dimitardimitrov13 for the update! Are there new PRs which we could add to #901?

@dimitardimitrov13
Copy link

Hello, there are no new PRs. I have addressed the comments above and also fixed the issue that @philippthun discovered with Mkdir. New test cases have been added to cover the implementation in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc CFF community RFC
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants