-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC0030] Updates #1008
[RFC0030] Updates #1008
Conversation
* Binding name collision behaviour * `VCAP_SERVICES` attribute translation
@philippthun, @dimitardimitrov13 could you pls also check on this updates. |
@dimitardimitrov13, is currently off. Expect update from hiм Monday at the earliest. I'll also take a look. |
Hello, @beyhan, I'm starting the refactoring for all impacted projects: bbs, protobuffers, rep, executor and diego-release. |
@philippthun described the mapping process in details: cloudfoundry/cloud_controller_ng#4036 |
Hello, All changes requested in this PR have been addressed. Thank you. |
Thank you @dimitardimitrov13 for the update! Are there new PRs which we could add to #901? |
Hello, there are no new PRs. I have addressed the comments above and also fixed the issue that @philippthun discovered with Mkdir. New test cases have been added to cover the implementation in more detail. |
VCAP_SERVICES
attribute translationServiceBindingFiles
toVolumeMountedFiles
to avoid CF terminology leaking into BBS's domain modelFiles
toFile
,Name
toPath
andValue
toContent
for better readability