Update branch protection rules for CLI bosh-package-cf-cli-release #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/cloudfoundry/bosh-package-cf-cli-release contains no real coding but is a packaging project. So I have no concerns by excluding this project from branch protection (in contrast to https://github.com/cloudfoundry/cli). But can you share your arguments in favour of deploy tokens compared with bot users (which are excluded from branch protection anyway)? |
|
/rebase |
After internal discussion, we decided to keep using workflow tokens to push release updates directly to the branch.
|
@Gerg, can you please review this PR? |
|
Please merge if this change looks ok, as this constantly breaks our release process. |
|
I can merge this to unblock y'all, but Stephan was curious about why we couldn't use the ARI bot account for this repo? |
Gerg
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After internal discussion, we decided to keep using workflow tokens to push release updates directly to the branch.