Credhub CLI no longer writes credentials to terminal during the

regenerate operation [#157789350] CredHub CLI does not write credentials to terminal during regenerate operation Signed-off-by: Chhavi Kankaria <[email protected]>
cloudfoundry · May 31, 2018 · c360e74 · c360e74
1 parent 0669050
commit c360e74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/commands/regenerate.go b/commands/regenerate.go
@@ -13,6 +13,7 @@ func (c *RegenerateCommand) Execute([]string) error {
 		return err
 	}
 
+	credential.Value = "<redacted>"
 	printCredential(c.OutputJSON, credential)
 
 	return nil

diff --git a/commands/regenerate_test.go b/commands/regenerate_test.go
@@ -38,7 +38,7 @@ var _ = Describe("Regenerate", func() {
 			Eventually(session).Should(Exit(0))
 			Eventually(session.Out).Should(Say("name: my-password-stuff"))
 			Eventually(session.Out).Should(Say("type: password"))
-			Eventually(session.Out).Should(Say("value: nu-potatoes"))
+			Eventually(session.Out).Should(Say("value: <redacted>"))
 
 		})
 
@@ -53,7 +53,7 @@ var _ = Describe("Regenerate", func() {
 			session := runCommand("regenerate", "--name", "my-password-stuffs", "--output-json")
 
 			Eventually(session).Should(Exit(0))
-			Expect(string(session.Out.Contents())).To(MatchJSON(fmt.Sprintf(STRING_CREDENTIAL_RESPONSE_JSON, "password", "my-password-stuffs", "nu-potatoes")))
+			Expect(string(session.Out.Contents())).To(MatchJSON(fmt.Sprintf(STRING_CREDENTIAL_RESPONSE_JSON, "password", "my-password-stuffs", "<redacted>")))
 		})
 
 		It("prints error when server returns an error", func() {