Add support for talking to NATS over mTLS #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
|
This was referenced May 19, 2021
|
/easycla |
|
@ameowlia EasyCLA is signed off, so this can get moving again 🎉 |
ameowlia
requested changes
Jul 2, 2021
There was a problem hiding this comment.
Did acceptance on the 2 PRs...
- ✅ GIVEN this is code is deployed, WHEN the opsfile is not applied THEN gorouter continued to use the non-tls nats endpoint.
- ✅ GIVEN this is code is deployed, WHEN the opsfile is applied THEN gorouter used the tls nats endpoint.
If you can edit this one fixme comment, then I will merge!
🙏 Thank you so much for your hard work on this!
Until now Gorouter has been unable to encrypt its connection to NATS. Mutual TLS has been added for other components that talk to NATS, but not to Gorouter. This commit adds support for configuring the NATS connection with Mutual TLS. This code is based heavily on the implementation in route-emitter [1]. The config YAML's structure gets some changes: the username and password is no longer provided separately for every NATS machine. This isn't a limitation in real-world Cloud Foundry deployments. Port is repeated for each NATS machine so that the integration tests can still run multiple NATS on multiple ports. [1] https://github.com/cloudfoundry/route-emitter/tree/master/diegonats
|
Removed an extra commit that had snuck in here 🤦🏻 fixed @ameowlia |
ameowlia
approved these changes
Jul 13, 2021
|
🎉 🐱 Thank you so much @46bit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change: this PR makes Gorouter able to talk to NATS via Mutual TLS. This can remove one of the remaining non-TLS uses within Cloud Foundry.
An explanation of the use cases your change solves: many organisations using Cloud Foundry want it to use TLS everywhere. This ensures no sensitive data can be snooped on the network, and helps with compliance.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics): followup PRs are coming shortly to cf-deployment and routing-release that can be deployed.
Expected result after the change: Gorouter will connect to NATS over Mutual TLS. Also, nothing will be left connecting to NATS over plaintext.
Links to any other associated PRs: Support Gorouter talking to NATS over mTLS routing-release#204 and Configure Gorouter to talk to NATS over mTLS cf-deployment#925
I have viewed signed and have submitted the Contributor License Agreement: this is actively in-progress
I have made this pull request to the
mainbranchI have run all the unit tests using
scripts/run-unit-tests-in-dockerfrom routing-release.(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
(Optional) I have run CF Acceptance Tests on bosh lite