Revert workflow go to stable #3040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewalter
force-pushed
the
revert-golang-pin
branch
from
94abcb6 to
6dba703
Compare
- Previously pinned due to hanging workloads tests - Update go.mod - Update Dockerfiles Co-authored-by: Dave Walter <[email protected]>
Birdrock
force-pushed
the
revert-golang-pin
branch
from
6dba703 to
7e21bd7
Compare
davewalter
approved these changes
Dec 12, 2023
|
@danail-branekov @georgethebeatle This appears to be passing and the setup-go output suggests it is using 1.21.5 (even though it has a lot of scary looking output). If you feel comfortable with it, go ahead an merge it. Otherwise, we can talk about it during the Working Group Forum. |
davewalter
added a commit
to cloudfoundry/korifi-ci
that referenced
this pull request
Dec 13, 2023
This reverts commit 9f464c2. We have merged cloudfoundry/korifi#3040 to bump to Golang 1.21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2768
What is this change about?
Unpinning golang version. 1.21.5 may resolve the issue.
Does this PR introduce a breaking change?
No,
Acceptance Steps
Allow GH actions workflow to complete.
Tag your pair, your PM, and/or team
@davewalter