Avoid Expect in the smoke test fail handler
#3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Expect`s in the fail handler could lead into the fail handler retriggering itself in case of the expectation failure. Instead of using `Expect`s we just log the error and return from the handler Co-authored-by: Danail Branekov <[email protected]>
danail-branekov
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-main/builds/1022
What is this change about?
Using
Expects in the fail handler could lead into the fail handlerretriggering itself in case of the expectation failure. Instead of using
Expects we just log the error and return from the handlerDoes this PR introduce a breaking change?
No
Acceptance Steps
Smoke tests complete