Expose Korifi API using Gateway API #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
approved these changes
Jan 9, 2024
* Use Gateway API objects to define the API ingress * Introduce a new required helm value `networking.gatewayClass` to reference the gateway class * Install contour with Gateway API static provisioning enabled * `install-dependencies` creates a gateway class called `contour` * Remove the now redundant api.expose helm value Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle
force-pushed
the
issues/3052-gateway-api
branch
from
09dae6a to
1e0a8a0
Compare
georgethebeatle
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3052
What is this change about?
networking.gatewayClasstoreference the gateway class
install-dependenciescreates a gateway class calledcontourDoes this PR introduce a breaking change?
No
Acceptance Steps
See #3052
Tag your pair, your PM, and/or team
@georgethebeatle