Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default the type credentials key in VCAP_SERVICES #3216

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

georgethebeatle
Copy link
Member

Is there a related GitHub Issue?

#3169

What is this change about?

  • Do not default type credentials key in VCAP_SERVICES
  • type has no special treatment outside the servicebinding.io secret
  • Remove the validation of the type value change from the service
    instance repository
  • Whenever the type value changes, the binding controller recreates
    the servicebinding.io secret with the new type. Recreation is needed
    as secrets' type is immutable

Does this PR introduce a breaking change?

No

Acceptance Steps

see story

@danail-branekov danail-branekov enabled auto-merge (rebase) April 17, 2024 09:58
* `type` has no special treatment outside the servicebinding.io secret
* Remove the validation of the `type` value change from the service
  instance repository
* Whenever the `type` value changes, the binding controller recreates
  the servicebinding.io secret with the new type. Recreation is needed
  as secrets' type is immutable

fixes #3169

WIP

Do not default/validate upsi credentials `type` in service instance
repository

Co-authored-by: Georgi Sabev <[email protected]>

WIP: binding controller recreates the secret on type change

Co-authored-by: Georgi Sabev <[email protected]>

wip

Co-authored-by: Georgi Sabev <[email protected]>
@danail-branekov danail-branekov merged commit 2c0edc5 into main Apr 17, 2024
11 checks passed
@danail-branekov danail-branekov deleted the issues/3169-no-type-in-vcap-services branch April 17, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants