Remove temporary helm values #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `statefulsetRunnerTemporarySetPodSeccompProfile` * `jobTaskRunnerTemporarySetPodSeccompProfile` Those helm values were introduced to avoid workloads restart on Korifi upgrade. With the upcoming release workloads would be restarted by an unrelated change anyway, so it is a convenient moment to get rid of those. issue #3164 Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle
force-pushed
the
issues/3164-remove-temporary-helm-values
branch
from
6768bbc to
0818a34
Compare
georgethebeatle
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3164
What is this change about?
Remove the following helm values:
statefulsetRunnerTemporarySetPodSeccompProfilejobTaskRunnerTemporarySetPodSeccompProfileThose helm values were introduced to avoid workloads restart on Korifi
upgrade. With the upcoming release workloads would be restarted by an
unrelated change anyway, so it is a convenient moment to get rid of
those.
Does this PR introduce a breaking change?
It causes workloads restart on Korifi upgrade