Adding v3/apps/guid/droplets endpoint; Fixes #3552 #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminguttmann-avtq
force-pushed
the
3552-add-droplets-endpoint
branch
3 times, most recently
from
195f7ed to
475ebca
Compare
danail-branekov
previously requested changes
Oct 31, 2024
|
@danail-branekov thanks for detailed feedback, will have a look into it next week :) |
benjaminguttmann-avtq
force-pushed
the
3552-add-droplets-endpoint
branch
from
8218839 to
a4b718f
Compare
georgethebeatle
force-pushed
the
3552-add-droplets-endpoint
branch
from
a4b718f to
b13e14f
Compare
benjaminguttmann-avtq
force-pushed
the
3552-add-droplets-endpoint
branch
3 times, most recently
from
ba21155 to
fe2a81b
Compare
|
@danail-branekov @georgethebeatle please review again |
There was a problem hiding this comment.
He @benjaminguttmann-avtq thank you for your efforts, nice catch using a label selector to make the server do the filtering for us!
I have left some minor comments in-line
georgethebeatle
dismissed
danail-branekov’s stale review
Comments have already been addressed
benjaminguttmann-avtq
force-pushed
the
3552-add-droplets-endpoint
branch
from
8cb7358 to
7842582
Compare
georgethebeatle
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
Fixes #3552
What is this change about?
Adding /v3/apps/guid/droplets endpoint
Does this PR introduce a breaking change?
No, adds a new endpoint
Acceptance Steps
Tag your pair, your PM, and/or team