-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DELETE /v3/service_offerings/:guid #3614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement delete handler and DeleteOffering in repo * Implement purging for Service Offerings - is purge is set to true, delete all related service plans, instances and bindings without contacting the service broker
67448fa
to
1ea629b
Compare
klapkov
commented
Nov 19, 2024
klapkov
commented
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
756f39e
to
9e3760e
Compare
georgethebeatle
previously approved these changes
Dec 6, 2024
auto-merge was automatically disabled
December 9, 2024 09:01
Head branch was pushed to by a user without write access
georgethebeatle
approved these changes
Dec 9, 2024
ddraganovv
pushed a commit
to ddraganovv/korifi
that referenced
this pull request
Dec 11, 2024
* Add DELETE /v3/service_offerings/:guid * Implement delete handler and DeleteOffering in repo * Implement purging for Service Offerings - is purge is set to true, delete all related service plans, instances and bindings without contacting the service broker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3613
What is this change about?
Here we add deleting and purging of service offeringsDoes this PR introduce a breaking change?
No