Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DELETE /v3/service_offerings/:guid #3614

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

klapkov
Copy link
Contributor

@klapkov klapkov commented Nov 18, 2024

Is there a related GitHub Issue?

#3613

What is this change about?

Here we add deleting and purging of service offerings

Does this PR introduce a breaking change?

No

  * Implement delete handler and DeleteOffering in repo
  * Implement purging for Service Offerings - is purge is set to true,
    delete all related service plans, instances and bindings without
    contacting the service broker
Copy link
Member

@danail-branekov danail-branekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

api/handlers/service_offering_test.go Outdated Show resolved Hide resolved
api/repositories/service_offering_repository_test.go Outdated Show resolved Hide resolved
api/repositories/service_offering_repository_test.go Outdated Show resolved Hide resolved
api/repositories/service_offering_repository_test.go Outdated Show resolved Hide resolved
georgethebeatle
georgethebeatle previously approved these changes Dec 6, 2024
auto-merge was automatically disabled December 9, 2024 09:01

Head branch was pushed to by a user without write access

@georgethebeatle georgethebeatle enabled auto-merge (squash) December 9, 2024 09:56
@georgethebeatle georgethebeatle merged commit d8705f9 into cloudfoundry:main Dec 9, 2024
10 checks passed
ddraganovv pushed a commit to ddraganovv/korifi that referenced this pull request Dec 11, 2024
* Add DELETE /v3/service_offerings/:guid
  * Implement delete handler and DeleteOffering in repo
  * Implement purging for Service Offerings - is purge is set to true,
    delete all related service plans, instances and bindings without
    contacting the service broker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants