Skip to content

Commit

Permalink
Remove mp4 image format from dts
Browse files Browse the repository at this point in the history
  • Loading branch information
strausr authored Jan 20, 2020
1 parent 6e85826 commit d3f5a61
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 9 deletions.
13 changes: 8 additions & 5 deletions test/api_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const itBehavesLike = helper.itBehavesLike;
const TEST_TAG = helper.TEST_TAG;
const UPLOAD_TAGS = helper.UPLOAD_TAGS;
const uploadImage = helper.uploadImage;
const TEST_ID = helper.TEST_ID;
const TEST_ID = Date.now();
const SUFFIX = helper.SUFFIX;
const PUBLIC_ID_PREFIX = "npm_api_test";
const PUBLIC_ID = PUBLIC_ID_PREFIX + SUFFIX;
Expand Down Expand Up @@ -47,6 +47,9 @@ const EXPLICIT_TRANSFORMATION2 = {
const METADATA_EXTERNAL_ID_UPLOAD = "metadata_upload_" + TEST_ID;
const METADATA_EXTERNAL_ID_UPDATE = "metadata_uploader_update_" + TEST_ID;
const METADATA_EXTERNAL_ID_EXPLICIT = "metadata_explicit_" + TEST_ID;
const LABEL_INT_1 = 'metadata_label_1_' + TEST_ID;
const LABEL_INT_2 = 'metadata_label_2_' + TEST_ID;
const LABEL_INT_3 = 'metadata_label_3_' + TEST_ID;

sharedExamples("a list with a cursor", function (testFunc, ...args) {
specify(":max_results", function () {
Expand Down Expand Up @@ -345,7 +348,7 @@ describe("api", function () {
});
});
it("should allow deleting derived resources by transformations", function () {
this.timeout(helper.TIMEOUT_LONG);
this.timeout(helper.TIMEOUT_LARGE);
return Q.all([
uploadImage({
public_id: PUBLIC_ID_1,
Expand Down Expand Up @@ -809,17 +812,17 @@ describe("api", function () {
[
cloudinary.v2.api.add_metadata_field({
external_id: METADATA_EXTERNAL_ID_UPDATE,
label: "subject",
label: LABEL_INT_1,
type: "string",
}),
cloudinary.v2.api.add_metadata_field({
external_id: METADATA_EXTERNAL_ID_UPLOAD,
label: "input",
label: LABEL_INT_2,
type: "string",
}),
cloudinary.v2.api.add_metadata_field({
external_id: METADATA_EXTERNAL_ID_EXPLICIT,
label: "field",
label: LABEL_INT_3,
type: "string",
}),
]
Expand Down
1 change: 1 addition & 0 deletions test/spechelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const api_http = String(config().upload_prefix).startsWith('http:') ? http : htt
exports.TIMEOUT_SHORT = 5000;
exports.TIMEOUT_MEDIUM = 20000;
exports.TIMEOUT_LONG = 50000;
exports.TIMEOUT_LARGE = 70000;
exports.SUFFIX = process.env.TRAVIS_JOB_ID || Math.floor(Math.random() * 999999);
exports.SDK_TAG = "SDK_TEST"; // identifies resources created by all SDKs tests
exports.TEST_TAG_PREFIX = "cloudinary_npm_test"; // identifies resources created by this SDK's tests
Expand Down
4 changes: 2 additions & 2 deletions test/structured_metadata_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const Q = require('q');
const cloudinary = require("../cloudinary");
const helper = require("./spechelper");

const TEST_ID = helper.TEST_ID;
const TEST_ID = Date.now();
const TEST_TAG = helper.TEST_TAG;
const UPLOAD_TAGS = helper.UPLOAD_TAGS;
const uploadImage = helper.uploadImage;
Expand Down Expand Up @@ -35,7 +35,7 @@ const LABEL_DATE = 'metadata_date_' + TEST_ID;
const api = cloudinary.v2.api;

describe("structured metadata api", function () {
this.timeout(helper.TIMEOUT_MEDIUM);
this.timeout(helper.TIMEOUT_LARGE);

before(function () {
return Q.allSettled(
Expand Down
3 changes: 1 addition & 2 deletions types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ declare module 'cloudinary' {
| "webp"
| "zip"
| "svg"
| "mp4"
| "webm"
| "wdp"
| "hpx"
Expand Down Expand Up @@ -839,7 +838,7 @@ declare module 'cloudinary' {
function upload_large(path: string, callback?: ErrorCallBack): Promise<any>;

function upload_stream(options?: UploadApiOptions, callback?: ErrorCallBack): Promise<any>;

function upload_stream(callback?: ErrorCallBack): Promise<any>;

function upload_tag_params(options?: UploadApiOptions, callback?: ErrorCallBack): Promise<any>;
Expand Down

0 comments on commit d3f5a61

Please sign in to comment.