Copyonwrite/248/add devcontainer setup #286
Conversation
copyonwrite
requested review from
drochow,
MR2011 and
dorneanu
as code owners
|
I think we should add a small note to our Readme that the devcontainer can be used for development |
|
Doesn't work on my system:
🤔 |
|
The error message complains about a conflicting port. Did you shutdown all other docker containers running? You are running on macOS? @MR2011 Had trouble with a conflicting setting in his VS Code preferences. Do you try to use the Makefile to run stuff? The whole idea is, that you just run/need VS Code locally with only the remote container plugin, everything else is provided by the devcontainer, key ready. We can also look into this together, although I have no idea about macOS etc. |
|
Well, it's not complaining about other services running that would occupy the port. Nonetheless, I have shut down the other Services and getting this error.
No I don't |
| command: sleep infinity | ||
|
|
||
| # Runs app on the same network as the database container, allows "forwardPorts" in devcontainer.json function. | ||
| network_mode: service:mariadb |
There was a problem hiding this comment.
I had to remove this line on IntelliJ to make the dev-container start
|
|
||
| ``` | ||
| make start-all-heureka | ||
| ``` | ||
|
|
||
| ### Devcontainers |
There was a problem hiding this comment.
Requirements would be helpful:
Which Docker environements is the expected to work on?
e.g.: Does it also work with Podman?
There was a problem hiding this comment.
Also:
If we decide not to investigate the Intellij/OSX combination, we may add to the documentation on which systems this setup is recommended/working.
|
@copyonwrite please use commit signing to sign your commits |
|
@copyonwrite Please use conventional commit format for commit messages and (more important) pull request titles |
… and set default AuthType to none
…blocking server start and seperate token test
* Initial support for devcontainers * Mound additional volume for heureka devcontainer * Add licence headers * Update README.md with devcontainer setup * Add environment test variables for devcontainer * Use devcontainer settings for tests in VSCode * Use string instead of boolean for SEED_MODE variable in docker-compose.yml * fix(test): added connection test for API Server * fix(test): use wait group for waiting for listening instead of periodic check * fix(test): removing AUTH_TYPE and AUTH_TOKEN_SECRET from compose yaml and set default AuthType to none * fix(test): added FirstListenThenServe to utility pkg and added in nonblocking server start and seperate token test --------- Co-authored-by: David Rochow <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]>
Description
This PR adds support for the devcontainer standard.
devcontainers work OOTB for VSCode with the remote container extension and all versions of IDEA IDEs.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist