-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rn): add resource name to additional entities #291
Conversation
I think we should, for ComponentVersion, only keep the version. If we keep the CCRN on the component Version we could throw away the component because a specific version of an image would e.g. have the following CCRN:
This would mean it would include the info that is currently within the component version: As a result, you could not attach the same version to multiple components, e.g., the same image/version on a mirror. We could also decide to do so but that I'd argue we can remove the component from the schema. |
Whats the agreement here? We leave away the CCRN on ComponentVersion? |
Let's remove CCRN from ComponentVersion then. @BlakePatterson @drochow |
CCRN is now removed from ComponentVersion and the conflicts with main are resolved. |
Co-authored-by: David Rochow <[email protected]>
* chore: remove generated code * Automatic application of license header * chore: remove bot license header * Automatic application of license header --------- Co-authored-by: License Bot <[email protected]>
…#330) Bumps [github.com/brianvoe/gofakeit/v7](https://github.com/brianvoe/gofakeit) from 7.0.4 to 7.1.1. - [Release notes](https://github.com/brianvoe/gofakeit/releases) - [Commits](brianvoe/gofakeit@v7.0.4...v7.1.1) --- updated-dependencies: - dependency-name: github.com/brianvoe/gofakeit/v7 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Reimsbach <[email protected]>
Co-authored-by: Michael Reimsbach <[email protected]>
Description
This PR adds resource name to four entities to make identification easier.
The Name field has been replaced with CCRN in the following entities:
And CCRN has been added to the following entity:
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Updated all existing tests (db, app, e2e) to use the CCRN field in place of Name for the first three entities, and added an additional test and additional checks to existing tests for the new CCRN field in Component Version. All tests pass locally.
Added to documentation?
Checklist