Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rn): add resource name to additional entities #291

Merged
merged 24 commits into from
Oct 29, 2024

Conversation

BlakePatterson
Copy link
Collaborator

Description

This PR adds resource name to four entities to make identification easier.

The Name field has been replaced with CCRN in the following entities:

  • Service
  • Component
  • Support Group

And CCRN has been added to the following entity:

  • Component Version

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Updated all existing tests (db, app, e2e) to use the CCRN field in place of Name for the first three entities, and added an additional test and additional checks to existing tests for the new CCRN field in Component Version. All tests pass locally.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MR2011
Copy link
Collaborator

MR2011 commented Oct 16, 2024

  1. Do we want to add the CCRN to IssueRepository as well?
  2. The ComponentVersion has now the two fields Version and CCRN. Do we want to keep them both?

WDY @dorneanu @drochow

@drochow
Copy link
Collaborator

drochow commented Oct 18, 2024

I think we should, for ComponentVersion, only keep the version.

If we keep the CCRN on the component Version we could throw away the component because a specific version of an image would e.g. have the following CCRN:

ccrn: registry=ghcr.io, account=cloudoperators, repo=heureka-core, digest=sha256:<somshaValue>

This would mean it would include the info that is currently within the component version:
"registry=ghcr.io, account=cloudoperators, repo=heureka-core"

As a result, you could not attach the same version to multiple components, e.g., the same image/version on a mirror.

We could also decide to do so but that I'd argue we can remove the component from the schema.

@drochow
Copy link
Collaborator

drochow commented Oct 22, 2024

Whats the agreement here? We leave away the CCRN on ComponentVersion?

@drochow drochow added the question Further information is requested label Oct 22, 2024
@MR2011
Copy link
Collaborator

MR2011 commented Oct 22, 2024

Let's remove CCRN from ComponentVersion then. @BlakePatterson @drochow

@BlakePatterson
Copy link
Collaborator Author

CCRN is now removed from ComponentVersion and the conflicts with main are resolved.

MR2011 and others added 14 commits October 29, 2024 13:50
* chore: remove generated code

* Automatic application of license header

* chore: remove bot license header

* Automatic application of license header

---------

Co-authored-by: License Bot <[email protected]>
…#330)

Bumps [github.com/brianvoe/gofakeit/v7](https://github.com/brianvoe/gofakeit) from 7.0.4 to 7.1.1.
- [Release notes](https://github.com/brianvoe/gofakeit/releases)
- [Commits](brianvoe/gofakeit@v7.0.4...v7.1.1)

---
updated-dependencies:
- dependency-name: github.com/brianvoe/gofakeit/v7
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Reimsbach <[email protected]>
@MR2011 MR2011 merged commit da6debe into main Oct 29, 2024
7 checks passed
@MR2011 MR2011 deleted the BlakePatterson/issue_241/add-ccrn-to-entities branch October 29, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(rn): add resourcename to additional entities
6 participants