feat(scanner): Change logic of creating entities #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drochow
reviewed
Oct 21, 2024
MR2011
reviewed
Oct 21, 2024
|
|
||
| - Go 1.15 or later | ||
| - Access to a Kubernetes cluster | ||
| - Heureka system for reporting findings |
There was a problem hiding this comment.
Are we expecting certain labels on the Kubernetes pods?
There was a problem hiding this comment.
We do but its configurable no?
There was a problem hiding this comment.
What do you mean? "expecting certain labels" should also be part of the README?
There was a problem hiding this comment.
Yes, this is referring back to the fact that we build support groups from certain labels / annotations on the kubernetes resources
MR2011
reviewed
Oct 21, 2024
drochow
previously approved these changes
Oct 22, 2024
drochow
approved these changes
Oct 22, 2024
drochow
deleted the
dorneanu/issue-278/Change-logic-of-entity-creation
branch
dustindemmerle
pushed a commit
that referenced
this pull request
Oct 23, 2024
* First commit * Wip * Revert f04feab * Wip * Wip * Wip * Wip * Wip * Wip * Change naming * Add concurrency * Add READMEs * Automatic application of license header * Fix #309 (comment) * Fix #discussion_r1808503568 * Fix #309 (comment) * Fix #309 (comment) * Automatic application of license header * Fix #309 (comment) * Refactoring * Update dependencies * Fix logic for ExtractImageInfo * Add unit tests for ExtractImageInfo * Automatic application of license header * Clean-up --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in Issue #279 due to performance issues we decided to change the order and also the logic how entities are created in the different scanners.
The k8s-scanner will now create
ComponentsandComponentVersionobjects based on the information gets from the K8s scanner.The
keppelscanner will now fetch thetrivyreport only for available components, component versions in the DB. It will then createIssueobjects.What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist