Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove go:generate and add code gen to dockerfile #345

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore: remove go:generate and add code gen to dockerfile #345

merged 1 commit into from
Oct 31, 2024

Conversation

MR2011
Copy link
Collaborator

@MR2011 MR2011 commented Oct 31, 2024

Description

Generating the code via go generate caused issues with resolving some imports. Therefore, the code generation has been moved into the Dockerfile.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@drochow drochow merged commit 16281cf into main Oct 31, 2024
7 checks passed
@drochow drochow deleted the mr2011/-/dockerfile-code-generation branch October 31, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drochow drochow drochow approved these changes

@dorneanu dorneanu Awaiting requested review from dorneanu dorneanu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MR2011 @drochow