Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(makefile): add targets for generation and testing #88

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Conversation

MR2011
Copy link
Collaborator

@MR2011 MR2011 commented Jul 26, 2024

No description provided.

@MR2011 MR2011 requested a review from drochow as a code owner July 26, 2024 12:27
michalkrzyz
michalkrzyz previously approved these changes Jul 26, 2024
drochow
drochow previously approved these changes Jul 30, 2024
@drochow drochow dismissed stale reviews from michalkrzyz and themself via 3428ed6 July 30, 2024 07:03
drochow
drochow previously approved these changes Jul 30, 2024
Makefile Outdated
ginkgo internal/app

test-db:
ginkgo internal/database/mariadb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add fmt target as well:

fmt:
	go fmt ./...

michalkrzyz
michalkrzyz previously approved these changes Jul 30, 2024
@MR2011 MR2011 dismissed stale reviews from michalkrzyz and drochow via b94e949 July 30, 2024 07:25
@drochow drochow merged commit 7c0d9e9 into main Jul 31, 2024
4 checks passed
@drochow drochow deleted the makefile branch July 31, 2024 07:31
dustindemmerle pushed a commit that referenced this pull request Aug 6, 2024
* chore(makefile): add targets for generation and testing

* docs(mockery): added mockery section to readme

* chore(makefile): add fmt

---------

Co-authored-by: David Rochow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants