Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message with markdown #1067

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samtholiya
Copy link
Collaborator

@samtholiya samtholiya commented Feb 15, 2025

what

  • We update the error message to markdown.

why

  • To improve the user experience of the help

references

@mergify mergify bot added the triage Needs triage label Feb 15, 2025
@osterman
Copy link
Member

Let's pause on this and have a separate discussion on how we handle errors that are returned. The fact that we don't use different error types and have these formatted return values for log events is a bad pattern that we continue to double down on. Returning errors is one thing and formatting them for log output is another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants