Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Output in Atmos Tests #923

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Reduce Output in Atmos Tests #923

wants to merge 17 commits into from
+199 −29

Conversation

Cerebrovinny
Copy link
Collaborator

@Cerebrovinny Cerebrovinny commented Jan 9, 2025 •
edited
Loading

what

  • Introduced verbosity levels. Allows customizable detail.
  • Updated GitHub Actions: Modified test execution. Added verbosity control.
  • Improved Logging: Validated logs-level flag. Ensures correct log levels.
  • Updated README: Documented test verbosity. Guides on usage.

why

  • Reduces redundant output.
  • CI/CD: Provides clearer feedback

references

@mergify mergify bot added the triage Needs triage label Jan 9, 2025
@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label Jan 10, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 10, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jan 10, 2025
@mergify mergify bot removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels Jan 10, 2025
@Cerebrovinny Cerebrovinny reopened this Jan 10, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 10, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jan 10, 2025
@Cerebrovinny Cerebrovinny force-pushed the DEV-2909 branch 2 times, most recently from b209fb3 to f860550 Compare January 11, 2025 19:03
@Cerebrovinny Cerebrovinny marked this pull request as ready for review January 14, 2025 11:47
@Cerebrovinny Cerebrovinny requested review from a team as code owners January 14, 2025 11:47
osterman
osterman reviewed Jan 14, 2025
View reviewed changes
.github/workflows/test.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of tests were unintentionally deleted from this file.

Copy link
Collaborator Author

@Cerebrovinny Cerebrovinny Jan 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that to test the output of robherley/go-test-action@v0 in actions, its added back

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw this is not very good, not able to make it work properly so for now I recommend we stick with our main tests only

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"this is not very good"

Not sure what it refers to.

tests/cli_test.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have significantly factored this in a separate branch that I was unable to push due to the outages on GitHub last night. Unfortunately, this would be a very dirty merge so could we leave out changes to this file?

@Cerebrovinny Cerebrovinny requested a review from aknysh January 14, 2025 12:59
osterman
osterman reviewed Jan 14, 2025
View reviewed changes
Makefile
Comment on lines +60 to +66
@if [ "$(TEST_VERBOSITY)" = "quiet" ]; then \
ATMOS_TEST_VERBOSITY=$(TEST_VERBOSITY) go test ./... -timeout 20m; \
elif [ "$(TEST_VERBOSITY)" = "verbose" ]; then \
ATMOS_TEST_VERBOSITY=$(TEST_VERBOSITY) go test -v -count=1 ./... -timeout 20m; \
else \
ATMOS_TEST_VERBOSITY=$(TEST_VERBOSITY) go test -v ./... -timeout 20m; \
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what benefit this translation brings. Why not just set the variable needed, rather than translate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman left review comments

@aknysh aknysh Awaiting requested review from aknysh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-cloudposse Needs Cloud Posse assistance no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cerebrovinny @osterman