Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache installs #53

Closed
wants to merge 14 commits into from
Closed

feat: cache installs #53

wants to merge 14 commits into from

Conversation

dudymas
Copy link

@dudymas dudymas commented Dec 21, 2023

what

  • use github's cache/restore and cache/save workflows

why

  • Some end users hit API limits on app installs
  • Constantly reinstalling is a waste of compute, net, and IO

references:

Copy link
Member

@goruha goruha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic using cache should be inside actions that perform installation.

for example inside

cloudpoose/setup-atmos

@hans-d
Copy link

hans-d commented Mar 3, 2024

@dudymas can you resolve the merge conflict?

@hans-d hans-d added the stale This PR has gone stale label Mar 3, 2024
@dudymas
Copy link
Author

dudymas commented Mar 19, 2024

@dudymas can you resolve the merge conflict?

@hans-d updated. @goruha , I forget if this is still something we want in 'terraform-plan', or if this was fixed by the atmos install action.

@goruha
Copy link
Member

goruha commented Jul 25, 2024

@dudymas thanks for PR.
I think we should split caches .terraform and cli tools cache.

Check this #83

@goruha goruha closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This PR has gone stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants