add aws_backup_vault_lock_configuration
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benbentwo
requested review from
johncblandii and
florian0410
and removed request for
a team
Benbentwo
changed the title
aws_backup_vault_lock_configuration
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aknysh
requested changes
Jan 26, 2024
|
/terratest |
aknysh
reviewed
Jan 26, 2024
examples/complete/main.tf
Outdated
| @@ -4,7 +4,7 @@ provider "aws" { | |||
|
|
|||
| module "vpc" { | |||
| source = "cloudposse/vpc/aws" | |||
| version = "0.17.0" | |||
| version = "2.1.1" | |||
|
|
|||
| cidr_block = "172.16.0.0/16" | |||
There was a problem hiding this comment.
since you bumped the major version, I think cidr_block needs to be updated
There was a problem hiding this comment.
see https://github.com/cloudposse/terraform-aws-eks-cluster/blob/main/examples/complete/main.tf
please check all other attributes in all modules
aknysh
reviewed
Jan 26, 2024
There was a problem hiding this comment.
please see comments
https://github.com/cloudposse/actions/actions/runs/7672999661/job/20914694482
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
|
/terratest |
aknysh
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adds support for
aws_backup_vault_lock_configurationresourceswhy
Prevents Backups from being deleted for compliance or governance reasons
references