Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EFS volume configuration getting discarded #284

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix EFS volume configuration getting discarded #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0545ec
fix EFS volume configuration getting discarded
jean-francois-sa Jul 13, 2023
9612fb6
Merge branch 'main' into aka/fix-efs-volumes-missing
RoseSecurity Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ module "ecs_alb_service_task" {
subnet_ids = var.ecs_private_subnet_ids
container_port = var.container_port
nlb_container_port = var.nlb_container_port
docker_volumes = var.volumes
docker_volumes = [for volume in var.volumes : volume if length(volume.docker_volume_configuration) > 0]
efs_volumes = [for volume in var.volumes : volume if length(volume.efs_volume_configuration) > 0]
kevcube marked this conversation as resolved.
Show resolved Hide resolved
ecs_load_balancers = local.load_balancers
deployment_controller_type = var.deployment_controller_type
deployment_maximum_percent = var.deployment_maximum_percent
Expand Down