Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

248 - Fix planning failure #254

Merged
merged 1 commit into from
Feb 11, 2025
Merged

248 - Fix planning failure #254

merged 1 commit into from
Feb 11, 2025
+2 −2

Conversation

rtisma
Copy link
Contributor

@rtisma rtisma commented Feb 11, 2025 •
edited
Loading

what

  • terraform plan does not error out now when the module is disabled.

why

  • skip coalescing null values when the module is disabled
  • applies only to local.endpoint_address and local.reader_endpoint_address

references

closes #248

@rtisma rtisma requested review from a team as code owners February 11, 2025 16:11
@mergify mergify bot added the triage Needs triage label Feb 11, 2025
@RoseSecurity
Copy link

/terratest

RoseSecurity
RoseSecurity approved these changes Feb 11, 2025
View reviewed changes
Copy link

@RoseSecurity RoseSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement!

@RoseSecurity RoseSecurity merged commit 0a08ea0 into cloudposse:main Feb 11, 2025
28 checks passed
@mergify mergify bot removed the triage Needs triage label Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

These changes were released in v1.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoseSecurity RoseSecurity RoseSecurity approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planning fails when module is disabled
2 participants
@rtisma @RoseSecurity