wip: Upgrade to webdriverio 9 #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gethinwebster
requested review from
michaeldowseza
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 91.11% 92.32% +1.21%
==========================================
Files 18 18
Lines 394 391 -3
Branches 63 55 -8
==========================================
+ Hits 359 361 +2
+ Misses 31 30 -1
+ Partials 4 0 -4 ☔ View full report in Codecov by Sentry. |
| @@ -52,7 +53,8 @@ export default abstract class BrowserCreator { | |||
| await browser.setTimeout({ implicit: options.implicitTimeout, script: options.scriptTimeout }); | |||
|
|
|||
| if (!browser.isMobile) { | |||
| await browser.$('body').then(body => body.moveTo({ xOffset: 0, yOffset: 0 })); | |||
| const body = await browser.$('//body'); | |||
| body.moveTo({ xOffset: 0, yOffset: 0 }); | |||
There was a problem hiding this comment.
What is the return of moveTo? Is it a promise?
There was a problem hiding this comment.
ah good catch! webdriverio 9 does a lot more promise chaining magic under the hood, so it might be that it handles this anyway, but makes sense to make it more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: AWSUI-51276
Description of changes:
WIP of upgrading to webdriverio. However, some outstanding bugs need to be fixed on webdriverio side before this can continue:
$('body')returns no results in v9 webdriverio/webdriverio#13440By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.