Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades WebdriverIO to v9 #109

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5,811 changes: 4,068 additions & 1,743 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@
"dependencies": {
"@aws-sdk/client-device-farm": "^3.623.0",
"@types/pngjs": "^6.0.4",
"@wdio/globals": "^9.1.4",
"@wdio/types": "^9.1.3",
"get-stream": "^6.0.1",
"lodash": "^4.17.21",
"p-retry": "^4.6.2",
"pixelmatch": "^5.3.0",
"pngjs": "^6.0.0",
"wait-on": "^7.2.0",
"webdriverio": "^7.25.2"
"webdriverio": "^9.1.4"
},
"devDependencies": {
"@types/lodash": "^4.14.186",
Expand Down
12 changes: 7 additions & 5 deletions src/browsers/browser-creator.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
import { remote, RemoteOptions } from 'webdriverio';

import { remote } from 'webdriverio';
import { Options } from '@wdio/types';
import merge from 'lodash/merge';

import { BrowserError } from '../exceptions';
import { Capabilities } from './capabilities';

export interface WebDriverOptions {
width: number;
Expand All @@ -13,7 +14,7 @@ export interface WebDriverOptions {
implicitTimeout: number;
scriptTimeout: number;
baseUrl?: string;
logLevel: RemoteOptions['logLevel'];
logLevel: Options.WebDriverLogTypes;
capabilities?: Record<string, any>;
}

Expand Down Expand Up @@ -52,7 +53,8 @@ export default abstract class BrowserCreator {
await browser.setTimeout({ implicit: options.implicitTimeout, script: options.scriptTimeout });

if (!browser.isMobile) {
await browser.$('body').then(body => body.moveTo({ xOffset: 0, yOffset: 0 }));
const body = await browser.$('body');
await body.moveTo({ xOffset: 0, yOffset: 0 });
await browser.setWindowSize(options.width, options.height);
}

Expand All @@ -75,5 +77,5 @@ export default abstract class BrowserCreator {
}

protected abstract __getBrowserUrl(): Promise<URL>;
protected abstract __getCapabilities(): Capabilities;
protected abstract __getCapabilities(): WebdriverIO.Capabilities;
}
8 changes: 4 additions & 4 deletions src/browsers/browserstack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,19 @@ import { URL } from 'url';
import pRetry, { AbortError } from 'p-retry';
import BrowserCreator, { WebDriverOptions } from './browser-creator';
import { BrowserStackFullQueueErrorText } from '../exceptions';
import { Capabilities, getCapability } from './capabilities';
import { getCapability } from './capabilities';

const N_SEC_SLEEP_BEFORE_RETRY = 30;

const browserStackHub = 'https://hub.browserstack.com/wd/hub';

const browsers: Record<string, Capabilities> = {
const browsers: Record<string, WebdriverIO.Capabilities> = {
Firefox: {
browserName: 'firefox',
// Leave blank so we get the latest version. 'beta' is also a valid option
// browserVersion: '69.0',
'bstack:options': {
seleniumVersion: '3.14.0',
seleniumVersion: '4.25.0',
os: 'Windows',
osVersion: '10',
},
Expand Down Expand Up @@ -111,7 +111,7 @@ export default class BrowserStackBrowserCreator extends BrowserCreator {
return new URL(browserStackHub);
}

protected __getCapabilities(): Capabilities {
protected __getCapabilities(): WebdriverIO.Capabilities {
const capabilities = getCapability(this.browserName, browsers);
const browserstackOptions = this.options as BrowserstackOptions;
return {
Expand Down
12 changes: 7 additions & 5 deletions src/browsers/capabilities.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

import lodash from 'lodash';
import { RemoteOptions } from 'webdriverio';
import { FatalError } from '../exceptions';

export type Capabilities = RemoteOptions['capabilities'];

const defaultCapabilities: Record<string, Capabilities> = {
const defaultCapabilities: Record<string, WebdriverIO.Capabilities> = {
Chrome: {
browserName: 'chrome',
},
Expand Down Expand Up @@ -63,6 +61,7 @@ const defaultCapabilities: Record<string, Capabilities> = {
Firefox: {
browserName: 'firefox',
'moz:firefoxOptions': {
args: ['-headless'],
prefs: {
'fission.webContentIsolationStrategy': 0,
'fission.bfcacheInParent': false,
Expand All @@ -77,7 +76,10 @@ const defaultCapabilities: Record<string, Capabilities> = {
},
};

export function getCapability(browserName: string, capabilities: Record<string, Capabilities>): Capabilities {
export function getCapability(
browserName: string,
capabilities: Record<string, WebdriverIO.Capabilities>
): WebdriverIO.Capabilities {
if (!(browserName in capabilities)) {
throw new FatalError(`Browser ${browserName} is not supported in this provider`);
}
Expand Down
6 changes: 3 additions & 3 deletions src/browsers/devicefarm-mobile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
// SPDX-License-Identifier: Apache-2.0
import { URL } from 'url';
import BrowserCreator from './browser-creator';
import { Capabilities, getCapability } from './capabilities';
import { getCapability } from './capabilities';

// The remaining options like browserName, deviceName, etc. will be covered
// by default capabilities in DeviceFarm and/or the Appium server.
const mobileBrowsers: Record<string, Capabilities> = {
const mobileBrowsers: Record<string, WebdriverIO.Capabilities> = {
iOS: {
'appium:automationName': 'XCUITest',
'appium:platformName': 'iOS',
Expand All @@ -24,7 +24,7 @@ export default class MobileBrowserCreator extends BrowserCreator {
return new URL(this.options.seleniumUrl);
}

__getCapabilities(): Capabilities {
__getCapabilities(): WebdriverIO.Capabilities {
return getCapability(this.browserName, mobileBrowsers);
}
}
4 changes: 2 additions & 2 deletions src/browsers/devicefarm.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { URL } from 'url';
import { DeviceFarm } from '@aws-sdk/client-device-farm';
import BrowserCreator from './browser-creator';
import defaultCapabilities, { Capabilities, getCapability } from './capabilities';
import defaultCapabilities, { getCapability } from './capabilities';
import { FatalError } from '../exceptions';

export interface DevicefarmOptions {
Expand All @@ -28,7 +28,7 @@ export default class DevicefarmBrowserCreator extends BrowserCreator {
return new URL(response.url);
}

protected __getCapabilities(): Capabilities {
protected __getCapabilities(): WebdriverIO.Capabilities {
return getCapability(this.browserName, defaultCapabilities);
}
}
11 changes: 7 additions & 4 deletions src/browsers/local.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
// SPDX-License-Identifier: Apache-2.0
import { URL } from 'url';
import BrowserCreator from './browser-creator';
import defaultCapabilities, { Capabilities, getCapability, mergeCapabilities } from './capabilities';
import defaultCapabilities, { getCapability, mergeCapabilities } from './capabilities';

const localBrowsers: Record<string, Capabilities> = {
const localBrowsers: Record<string, WebdriverIO.Capabilities> = {
...defaultCapabilities,
ChromeHeadless: mergeCapabilities(defaultCapabilities.ChromeHeadless, {
'goog:chromeOptions': {
Expand All @@ -15,14 +15,17 @@ const localBrowsers: Record<string, Capabilities> = {
},
},
},
// Workaround for https://github.com/webdriverio/webdriverio/issues/13440
'wdio:enforceWebDriverClassic': true,
}),
ChromeHeadlessIntegration: mergeCapabilities(defaultCapabilities.ChromeHeadless, {
'goog:chromeOptions': {
args: ['--force-prefers-reduced-motion'],
},
// Workaround for https://github.com/webdriverio/webdriverio/issues/13440
'wdio:enforceWebDriverClassic': true,
}),
Firefox: mergeCapabilities(defaultCapabilities.Firefox, {
// https://firefox-source-docs.mozilla.org/testing/geckodriver/Capabilities.html
'moz:debuggerAddress': true,
}),
};
Expand All @@ -32,7 +35,7 @@ export default class LocalBrowserCreator extends BrowserCreator {
return new URL(this.options.seleniumUrl);
}

__getCapabilities(): Capabilities {
__getCapabilities(): WebdriverIO.Capabilities {
return getCapability(this.browserName, localBrowsers);
}
}
94 changes: 42 additions & 52 deletions src/page-objects/base.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ import { getElementCenter } from './utils';

import { ElementRect } from './types';
import { waitForTimerAndAnimationFrame } from './browser-scripts';
import { Browser } from 'webdriverio';

export default class BasePageObject {
constructor(protected browser: WebdriverIO.Browser) {}
constructor(protected browser: Browser) {}

async pause(milliseconds: number) {
await this.browser.pause(milliseconds);
Expand Down Expand Up @@ -50,56 +51,45 @@ export default class BasePageObject {
}

async buttonDownOnElement(selector: string) {
// buttonDown exists only in JSON Wire protocol
if (this.browser.buttonDown) {
await this.hoverElement(selector);
await this.browser.buttonDown();
} else {
// Clean up all previous actions before stating a new batch. Without this line Safari emits extra "mouseup" events
await this.browser.releaseActions();
const box = await this.getBoundingBox(selector);
const center = getElementCenter(box);
// W3C alternative is `performActions`. All consecutive actions have to be a part of a single call
await this.browser.performActions([
{
type: 'pointer',
id: 'mouse',
parameters: { pointerType: 'mouse' },
actions: [
{ type: 'pointerMove', duration: 0, x: center.x, y: center.y },
{ type: 'pointerDown', button: 0 },
// extra delay to let event listeners to be fired
{ type: 'pause', duration: 10 },
],
},
]);
}
// Clean up all previous actions before stating a new batch. Without this line Safari emits extra "mouseup" events
await this.browser.releaseActions();
const box = await this.getBoundingBox(selector);
const center = getElementCenter(box);
// W3C alternative is `performActions`. All consecutive actions have to be a part of a single call
await this.browser.performActions([
{
type: 'pointer',
id: 'mouse',
parameters: { pointerType: 'mouse' },
actions: [
{ type: 'pointerMove', duration: 0, x: center.x, y: center.y },
{ type: 'pointerDown', button: 0 },
// extra delay to let event listeners to be fired
{ type: 'pause', duration: 10 },
],
},
]);
}

async buttonUp() {
// buttonUp exists only in JSON Wire protocol
if (this.browser.buttonUp) {
await this.browser.buttonUp();
} else {
// W3C alternative is `performActions`
await this.browser.performActions([
{
type: 'pointer',
id: 'mouse',
parameters: { pointerType: 'mouse' },
actions: [
{ type: 'pointerUp', button: 0 },

// extra delay for Safari to process the event before moving the cursor away
{ type: 'pause', duration: 10 },
// return cursor back to the corner to avoid hover effects on screenshots
{ type: 'pointerMove', duration: 0, x: 0, y: 0 },
],
},
]);
// make sure all controls are properly released to avoid conflicts with further actions
await this.browser.releaseActions();
}
// W3C alternative is `performActions`
await this.browser.performActions([
{
type: 'pointer',
id: 'mouse',
parameters: { pointerType: 'mouse' },
actions: [
{ type: 'pointerUp', button: 0 },

// extra delay for Safari to process the event before moving the cursor away
{ type: 'pause', duration: 10 },
// return cursor back to the corner to avoid hover effects on screenshots
{ type: 'pointerMove', duration: 0, x: 0, y: 0 },
],
},
]);
// make sure all controls are properly released to avoid conflicts with further actions
await this.browser.releaseActions();
}

async dragAndDrop(sourceSelector: string, xOffset = 0, yOffset = 0) {
Expand All @@ -112,7 +102,7 @@ export default class BasePageObject {
return element.getValue();
}

async setValue(selector: string, value: number | string | string[]) {
async setValue(selector: string, value: number | string) {
const element = await this.browser.$(selector);
await element.setValue(value);
}
Expand Down Expand Up @@ -174,7 +164,7 @@ export default class BasePageObject {
}

async isExisting(selector: string) {
const elements = await this.browser.$$(selector);
const elements = await this.browser.$$(selector).map(element => element);
return elements.length > 0;
}

Expand All @@ -185,7 +175,7 @@ export default class BasePageObject {

async isDisplayedInViewport(selector: string) {
const element = await this.browser.$(selector);
return element.isDisplayedInViewport();
return element.isDisplayed({ withinViewport: true });
}

async isClickable(selector: string) {
Expand Down Expand Up @@ -224,7 +214,7 @@ export default class BasePageObject {
}

async getElementsText(selector: string) {
const elements = await this.browser.$$(selector);
const elements = await this.browser.$$(selector).map(element => element);
return Promise.all(elements.map(async element => element.getText()));
}

Expand Down
3 changes: 2 additions & 1 deletion src/use-browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import { WebDriverOptions } from './browsers/browser-creator';
import getBrowserCreator from './browser';
import merge from 'lodash/merge';
import { Browser } from 'webdriverio';

type BrowserOptions = {
browserName: string;
Expand All @@ -29,7 +30,7 @@ function isFaviconError(error: Record<string, unknown>) {
}

interface TestFunction {
(browser: WebdriverIO.Browser): Promise<void> | void;
(browser: Browser): Promise<void> | void;
}

function useBrowser(optionsOverride: Partial<WebDriverOptions>, testFn: TestFunction): () => Promise<void>;
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"module": "commonjs",
"moduleResolution": "node",
"lib": ["es2017", "dom"],
"types": ["node", "webdriverio/async"],
"types": ["node", "@wdio/globals/types"],
"declaration": true,
"strict": true,
"skipLibCheck": true,
Expand Down
Loading