-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SupportPromptGroup #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiegeorge
force-pushed
the
kg/support-prompt
branch
from
January 23, 2025 20:02
5dbf4ac
to
2a643ba
Compare
katiegeorge
force-pushed
the
kg/support-prompt
branch
from
January 27, 2025 19:23
678874a
to
112fda9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 99.23% 99.11% -0.12%
==========================================
Files 19 26 +7
Lines 520 900 +380
Branches 61 129 +68
==========================================
+ Hits 516 892 +376
- Misses 4 8 +4 ☔ View full report in Codecov by Sentry. |
katiegeorge
requested review from
connorlanigan
and removed request for
a team
January 28, 2025 00:20
connorlanigan
requested changes
Jan 28, 2025
src/support-prompt-group/__tests__/support-prompt-group.test.tsx
Outdated
Show resolved
Hide resolved
src/support-prompt-group/__tests__/support-prompt-group.test.tsx
Outdated
Show resolved
Hide resolved
connorlanigan
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds SupportPromptGroup to Cloudscape.
It also adds necessary tests and utils to make it a single tab stop.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.