Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SupportPromptGroup #37

Merged
merged 28 commits into from
Jan 30, 2025
Merged

feat: Add SupportPromptGroup #37

merged 28 commits into from
Jan 30, 2025

Conversation

katiegeorge
Copy link
Member

@katiegeorge katiegeorge commented Jan 23, 2025

Description

This PR adds SupportPromptGroup to Cloudscape.

It also adds necessary tests and utils to make it a single tab stop.
image

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 98.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 99.11%. Comparing base (62fec21) to head (0a1e96b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/internal/events/index.ts 96.87% 2 Missing ⚠️
src/support-prompt-group/internal.tsx 98.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   99.23%   99.11%   -0.12%     
==========================================
  Files          19       26       +7     
  Lines         520      900     +380     
  Branches       61      129      +68     
==========================================
+ Hits          516      892     +376     
- Misses          4        8       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katiegeorge katiegeorge requested a review from a team as a code owner January 28, 2025 00:20
@katiegeorge katiegeorge requested review from connorlanigan and removed request for a team January 28, 2025 00:20
src/support-prompt-group/interfaces.ts Outdated Show resolved Hide resolved
src/support-prompt-group/focus-helpers.tsx Outdated Show resolved Hide resolved
src/support-prompt-group/internal.tsx Show resolved Hide resolved
src/support-prompt-group/internal.tsx Outdated Show resolved Hide resolved
src/support-prompt-group/internal.tsx Outdated Show resolved Hide resolved
@katiegeorge katiegeorge added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 07c1e30 Jan 30, 2025
39 of 40 checks passed
@katiegeorge katiegeorge deleted the kg/support-prompt branch January 30, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants