chore: Improve metrics format #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 99.30% 99.30% -0.01%
==========================================
Files 29 29
Lines 721 715 -6
Branches 193 186 -7
==========================================
- Hits 716 710 -6
Misses 5 5 ☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
metric-improvements
branch
from
f408f76 to
81162de
Compare
dpitcock
reviewed
Jan 30, 2025
|
|
||
| expect(window.panorama).toHaveBeenCalledWith( | ||
| 'trackCustomEvent', | ||
| expect.objectContaining({ eventType: 'custom', eventValue: '{"test":"value"}', eventDetail: '{"test":"detail"}' }) | ||
| expect.objectContaining({ eventValue: '{"test":"value"}', eventDetail: '{"test":"detail"}' }) |
There was a problem hiding this comment.
should this also contain a eventType: 'awsui'?
There was a problem hiding this comment.
Since it uses expect.objectContaining, it passes regardless.
I decided to skip, because testing this field is not a subject of this test. We have many others to do this check
dpitcock
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: AWSUI-60324
Description of changes:
Fixing metrics according to the guidance from the Panorama API owners
eventNameas it is a legacy fieldeventType: 'awsui'for everything we emit to make it more discoverable among other entrieseventContextThe final hierarchy of the fields is the following:
eventType (always "awsui" for us) -> eventContext (event in our system, typically a component usage) -> eventDetail (all metadata)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.