chore: Update metric length limits #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Jan 29, 2024
| @@ -122,43 +120,3 @@ describe('useComponentMetrics', () => { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('PanoramaClient', () => { | |||
There was a problem hiding this comment.
Extracted into a separate file, because this code does not have much to do with useComponentMetrics hook
| console.error(`Event context for metric is too long: ${metric.eventContext}`); | ||
| return; | ||
| } | ||
| if (!validateLength(metric.eventType, 50)) { |
There was a problem hiding this comment.
Added validation for all supported keys. This one is especially important, because it is shorter than others and we are likely to hit this limit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 94.52% 98.36% +3.84%
==========================================
Files 16 16
Lines 292 306 +14
Branches 57 62 +5
==========================================
+ Hits 276 301 +25
+ Misses 16 5 -11 ☔ View full report in Codecov by Sentry. |
just-boris
force-pushed
the
raise-limits
branch
from
0127019 to
1afaf8b
Compare
just-boris
force-pushed
the
raise-limits
branch
from
1afaf8b to
34c8546
Compare
just-boris
commented
Jan 29, 2024
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { MetricsTestHelper, Metrics } from '../metrics/metrics'; |
There was a problem hiding this comment.
Tests moved from components repo: cloudscape-design/components#1919
Al-Dani
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Bring these values up to date with the receiver's end.
"Dry-run / dry-run / Components unit tests" is expected to fail. They will pass after merging cloudscape-design/components#1919All passes nowBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.