Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds the z-index-constraint rule to stylelint #3150

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

orangevolon
Copy link
Contributor

Description

Adds the z-index-value-constraint stylelint rule to this repo.
The rule itself was added in this PR.

Related links, issue #, if available: AWSUI-55594

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@orangevolon orangevolon requested a review from a team as a code owner December 20, 2024 09:23
@orangevolon orangevolon requested review from pan-kot and removed request for a team December 20, 2024 09:23
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (c461af5) to head (51ae12a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3150    +/-   ##
========================================
  Coverage   96.40%   96.40%            
========================================
  Files         784      784            
  Lines       22134    22134            
  Branches     7593     7190   -403     
========================================
  Hits        21339    21339            
- Misses        743      788    +45     
+ Partials       52        7    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster self-requested a review December 20, 2024 10:31
@orangevolon orangevolon added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 938e31b Jan 2, 2025
38 checks passed
@orangevolon orangevolon deleted the alamiami/apply-styling-z-index branch January 2, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants