Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes dependencies on React <19 in test utils #3252

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Feb 5, 2025

Description

The PR updates the uses of Simulate test-util from React with a custom event dispatcher.

Depends on: #3252

Rel: AWSUI-60345

How has this been tested?

  • Existing unit tests pass with minor adjustments (calling change when the value remains the same now has no effect)
  • Dry-run
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 65.90909% with 15 lines in your changes missing coverage. Please review.

Project coverage is 96.38%. Comparing base (89612ae) to head (d311907).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/test-utils/dom/input/base-input.ts 64.28% 5 Missing ⚠️
src/test-utils/dom/prompt-input/index.ts 66.66% 5 Missing ⚠️
src/test-utils/dom/textarea/index.ts 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3252      +/-   ##
==========================================
- Coverage   96.44%   96.38%   -0.07%     
==========================================
  Files         791      791              
  Lines       22563    22599      +36     
  Branches     7728     7399     -329     
==========================================
+ Hits        21760    21781      +21     
- Misses        750      811      +61     
+ Partials       53        7      -46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant