chore: Reduce duplicated styles on button component #3254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created to "unblock" #3253. We're at the edge of a couple of the bundle size checks, and adding a new button variant pushed it over the edge. Taking a look at the CSS, I realized we were looping through and generating a chunk of CSS for each button variant, but a lot of it wasn't variant-dependent, so it didn't really belong in that for loop.
Just like that! A lot of pointless CSS removed (though with no particular user impact since I imagine it could easily be gzipped away)
How has this been tested?
Will run it in my pipeline to make sure the selector order changes didn't mess anything up visually. But it seems reasonable enough to have a reviewer assigned in the meantime.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.