feat: Showcase chart drill down features (links in keys and values) #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdhalees
reviewed
Dec 15, 2023
| <Link | ||
| external={true} | ||
| href="#" | ||
| ariaLabel={`See details for ${y} hours on ${series.title} (opens in a new tab)`} |
There was a problem hiding this comment.
opens a new tab is already provided by i18n provider https://github.com/cloudscape-design/components/blob/main/src/i18n/messages/all.en.json#L147
There was a problem hiding this comment.
Not if you use the ariaLabel prop, because then the ARIA label masks all content inside the link, including the icon, for the screen readers.
abdhalees
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update existing configurable dashboard demo to use our new API for chart drilldown features.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.