idk i just rewrote everything #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashbot
force-pushed
the
ts-api
branch
2 times, most recently
from
d2cc438 to
b3be7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soo... it works, for the most part. I tested it against the real components package and the docs look great at a glance (see this gist), but there's absolutely no way we're going to get 1:1 parity with TypeDoc. Personally, I think I would just verify the returned state manually, let some minor things (like property/union order, type name formatting) slide and override the documenter snapshots.
Got tired of playing telephone with the TypeDoc API; and if we're going to pull types and methods out of
typedoc/distanyway, we might as well use the better more direct TypeScript API. And it'll be a lot easier to keep up with new shiny TypeScript versions.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.