fix: barrier mem leak

cloudwego · Nov 28, 2023 · a9d3dd7 · a9d3dd7
1 parent 27be26a
commit a9d3dd7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/connection_reactor.go b/connection_reactor.go
@@ -74,6 +74,7 @@ func (c *connection) closeBuffer() {
 	}
 	if c.outputBuffer.Len() == 0 || onConnect != nil || onRequest != nil {
 		c.outputBuffer.Close()
+		c.outputBarrier.reset()
 		barrierPool.Put(c.outputBarrier)
 	}
 }

diff --git a/sys_exec.go b/sys_exec.go
@@ -62,6 +62,16 @@ type barrier struct {
 	ivs []syscall.Iovec
 }
 
+func (b *barrier) reset() {
+	for i := range b.bs {
+		b.bs[i] = nil
+	}
+	for i := range b.ivs {
+		b.ivs[i].Base = nil
+		b.ivs[i].Len = 0
+	}
+}
+
 // writev wraps the writev system call.
 func writev(fd int, bs [][]byte, ivs []syscall.Iovec) (n int, err error) {
 	iovLen := iovecs(bs, ivs)