feat: support encode zero value in protobuf to adjust to go proto2

cloudwego · Oct 17, 2024 · 9bc3832 · 9bc3832
1 parent f899030
commit 9bc3832
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,5 +1,5 @@
 [workspace]
-members = ["pilota", "pilota-build", "pilota-thrift-parser"]
+members = ["pilota", "pilota-build", "pilota-thrift-parser", "examples"]
 resolver = "2"
 
 [profile.bench]

diff --git a/pilota/Cargo.toml b/pilota/Cargo.toml
@@ -41,6 +41,7 @@ rand = "0.8"
 
 [features]
 unstable = []
+pb-encode-zero-value = []
 
 [[bench]]
 name = "faststr"

diff --git a/pilota/src/prost/encoding.rs b/pilota/src/prost/encoding.rs
@@ -1579,8 +1579,14 @@ macro_rules! map {
             VL: Fn(u32, &V) -> usize,
         {
             for (key, val) in values.iter() {
-                let skip_key = key == &K::default();
-                let skip_val = val == val_default;
+                let mut skip_key = key == &K::default();
+                let mut skip_val = val == val_default;
+
+                #[cfg(feature = "pb-encode-zero-value")]
+                {
+                    skip_key = false;
+                    skip_val = false;
+                }
 
                 let len = (if skip_key { 0 } else { key_encoded_len(1, key) })
                     + (if skip_val { 0 } else { val_encoded_len(2, val) });