Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: more fieldmask API #146

Merged
merged 25 commits into from
Dec 5, 2023
Merged

opt: more fieldmask API #146

merged 25 commits into from
Dec 5, 2023

Conversation

AsterDY
Copy link
Contributor

@AsterDY AsterDY commented Nov 24, 2023

Description

  • rename codegen-api SetFieldMask() to Set_FieldMask() to avoid conflict with user field name
  • add serdes API Marshal()/Unmarshal() for transporting fieldmask
  • optimize user document
  • add option FieldMaskHalfway to support mask for not-root struct

Motivation and Context

Related Issue

@AsterDY AsterDY requested review from a team as code owners November 24, 2023 13:54
HeyJavaBean
HeyJavaBean previously approved these changes Nov 27, 2023
@AsterDY AsterDY changed the title feat: rename SetFieldMask to Set_FieldMask opt: more fieldmask API Nov 28, 2023
HeyJavaBean
HeyJavaBean previously approved these changes Nov 29, 2023
@AsterDY AsterDY force-pushed the feat/rename_fieldmask_api branch from aefa4de to 474dbef Compare December 1, 2023 12:20
@HeyJavaBean HeyJavaBean merged commit f86a89a into main Dec 5, 2023
5 checks passed
@HeyJavaBean HeyJavaBean deleted the feat/rename_fieldmask_api branch December 5, 2023 06:22
HeyJavaBean pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants