feat: support build with keep_unknown_fields (#209) #520
ci.yaml
on: push
test-linux
1m 19s
test-linux-aarch64
2m 18s
test-macos
8m 37s
test-windows
14m 17s
lint
35s
CI is green
0s
Annotations
2 errors and 14 warnings
incorrect implementation of `partial_cmp` on an `Ord` type:
volo/src/loadbalance/consistent_hash.rs#L73
error: incorrect implementation of `partial_cmp` on an `Ord` type
--> volo/src/loadbalance/consistent_hash.rs:73:1
|
73 | / impl PartialOrd for VirtualNode {
74 | | fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
| | _______________________________________________________________________-
75 | || self.hash.partial_cmp(&other.hash)
76 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
77 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_partial_ord_impl_on_ord_type
= note: `#[deny(clippy::incorrect_partial_ord_impl_on_ord_type)]` on by default
|
lint
Clippy had exited with the 101 exit code
|
the borrowed expression implements the required traits:
volo/src/net/incoming.rs#L269
warning: the borrowed expression implements the required traits
--> volo/src/net/incoming.rs:269:34
|
269 | std::fs::remove_file(&path)?;
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
casting to the same type is unnecessary (`i32` -> `i32`):
volo/src/net/incoming.rs#L233
warning: casting to the same type is unnecessary (`i32` -> `i32`)
--> volo/src/net/incoming.rs:233:13
|
233 | libc::SOMAXCONN as i32
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `libc::SOMAXCONN`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`i32` -> `i32`):
volo/src/net/incoming.rs#L223
warning: casting to the same type is unnecessary (`i32` -> `i32`)
--> volo/src/net/incoming.rs:223:20
|
223 | return libc::SOMAXCONN as i32;
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `libc::SOMAXCONN`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`i32` -> `i32`):
volo/src/net/incoming.rs#L216
warning: casting to the same type is unnecessary (`i32` -> `i32`)
--> volo/src/net/incoming.rs:216:30
|
216 | Err(_) => return libc::SOMAXCONN as i32,
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `libc::SOMAXCONN`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
manual `RangeInclusive::contains` implementation:
volo/src/net/incoming.rs#L154
warning: manual `RangeInclusive::contains` implementation
--> volo/src/net/incoming.rs:154:16
|
154 | if b'0' <= c && c <= b'9' {
| ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'0'..=b'9').contains(&c)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
= note: `#[warn(clippy::manual_range_contains)]` on by default
|
lint
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.305.0. Please update to the latest version 2.306.0
|
test-macos
The following actions uses node12 which is deprecated and will be forced to run on node16: Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
test-macos
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-macos
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-macos
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-windows
The following actions uses node12 which is deprecated and will be forced to run on node16: Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
test-windows
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-windows
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test-windows
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|