fix: multiplex panic

cloudwego · Sep 1, 2023 · 2de1365 · 2de1365
1 parent cdc99ae
commit 2de1365
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/volo-thrift/Cargo.toml b/volo-thrift/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "volo-thrift"
-version = "0.7.1"
+version = "0.7.2"
 edition.workspace = true
 homepage.workspace = true
 repository.workspace = true

diff --git a/volo-thrift/src/codec/default/mod.rs b/volo-thrift/src/codec/default/mod.rs
@@ -134,6 +134,7 @@ impl<E: ZeroCopyEncoder, W: AsyncWrite + Unpin + Send + Sync + 'static> Encoder
         cx.stats_mut().set_write_size(real_size);
 
         let write_result = (|| async {
+            self.linked_bytes.reset();
             // then we reserve the size of the message in the linked bytes
             self.linked_bytes.reserve(malloc_size);
             // after that, we encode the message into the linked bytes
@@ -160,8 +161,6 @@ impl<E: ZeroCopyEncoder, W: AsyncWrite + Unpin + Send + Sync + 'static> Encoder
         // put write end here so we can also record the time of encode error
         cx.stats_mut().record_write_end_at();
 
-        // finally, don't forget to reset the linked bytes
-        self.linked_bytes.reset();
         match write_result {
             Ok(()) => Ok(()),
             Err(mut e) => {