Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(volo-build): escape keywords in code generation for idl service method arguments #496

Merged
merged 4 commits into from
Sep 18, 2024

chore: version

09e25e2
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(volo-build): escape keywords in code generation for idl service method arguments #496

chore: version
09e25e2
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Sep 14, 2024 in 1s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.83.0-nightly (0609062a9 2024-09-13)
  • cargo 1.83.0-nightly (c1fa840a8 2024-08-29)
  • clippy 0.1.82 (0609062 2024-09-13)

Annotations

Check warning on line 23 in examples/src/thrift/hello/server_panic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult

warning: `self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult
  --> examples/src/thrift/hello/server_panic.rs:23:9
   |
23 |         &self,
   |         ^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument
   = note: `#[warn(clippy::duplicate_underscore_argument)]` on by default

Check warning on line 482 in volo-http/src/server/route.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

elided lifetime has a name

warning: elided lifetime has a name
   --> volo-http/src/server/route.rs:482:65
    |
482 |     fn at<'a>(&'a self, path: &'a str) -> Result<matchit::Match<&RouteId>, MatcherError> {
    |           -- lifetime `'a` declared here                        ^ this elided lifetime gets resolved as `'a`

Check warning on line 482 in volo-http/src/server/route.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

elided lifetime has a name

warning: elided lifetime has a name
   --> volo-http/src/server/route.rs:482:64
    |
482 |     fn at<'a>(&'a self, path: &'a str) -> Result<matchit::Match<&RouteId>, MatcherError> {
    |           -- lifetime `'a` declared here                       ^ this elided lifetime gets resolved as `'a`
    |
    = note: `#[warn(elided_named_lifetimes)]` on by default

Check warning on line 62 in benchmark/src/perf/mem.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
  --> benchmark/src/perf/mem.rs:62:41
   |
62 |                     mem_usage_list.push(mem_usage as u64);
   |                                         ^^^^^^^^^^^^^^^^ help: try: `mem_usage`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default