chore(volo-http): use less Result in client
#509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukiiiteru
force-pushed
the
chore/less-result
branch
from
047355f
to
a7b3b71
Compare
This commit updates `Request` to `Result<Request>` in `RequestBuilder`, and makes the methods of `RequestBuilder` no longer use `Result` as the return type. These methods no longer return `Err` directly, but save it in `Result<Request>` and throw it when trying to send a request. Signed-off-by: Yu Li <[email protected]>
yukiiiteru
force-pushed
the
chore/less-result
branch
from
a7b3b71
to
ba0dcdb
Compare
PureWhiteWu
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are too many
Results in the return values ofRequestBuilder's methods, so a large number ofunwraps need to be used, resulting in a poor user experience.Solution
This PR updates
RequesttoResult<Request>inRequestBuilder, and makes the methods ofRequestBuilderno longer useResultas the return type.These methods no longer return
Errdirectly, but save it inResult<Request>and throw it when trying to send a request.