Skip to content

feat(volo-thrift): close connection when encounter error

Sign in for the full log view
GitHub Actions / clippy succeeded Aug 7, 2024 in 1s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.82.0-nightly (60d146580 2024-08-06)
  • cargo 1.82.0-nightly (fa6465836 2024-08-02)
  • clippy 0.1.82 (60d1465 2024-08-06)

Annotations

Check warning on line 62 in benchmark/src/perf/mem.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
  --> benchmark/src/perf/mem.rs:62:41
   |
62 |                     mem_usage_list.push(mem_usage as u64);
   |                                         ^^^^^^^^^^^^^^^^ help: try: `mem_usage`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 101 in volo-thrift/src/transport/pingpong/server.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

warning: redundant closure
   --> volo-thrift/src/transport/pingpong/server.rs:101:50
    |
101 | ...                   resp.map_err(|e| server_error_to_application_exception(e)),
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `server_error_to_application_exception`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default