-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error message when sharing dataset with user #1140
error message when sharing dataset with user #1140
Conversation
strange bug - sharing with group shows 2 entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay.
I was wondering why it was previously needed to explicitly check for user role and verify if the user was added on frontend. Looks like @tcnichol you wrote this code. Do you remember?
…-dataset-with-user
…rror-shown-when-sharing-dataset-with-user
I think if I didn't do this the page did not show the user that was added correctly. |
I looked at the db here. Looks like it is working as intended. A user does not have multiple roles on any dataset, their id is removed from the old Authorization object. That object is not deleted because other user_ids might be in that object. If it is empty, then if you add a user with that role, that existing authorization is updated with the user_id added. |
Previously when you shared a dataset with a user, it showed an error message but the user was added.
I have fixed this so now you get the success message.