Fix polar_training2gpx having empty "samples" #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hope this will fix cmaion#47 : polar_training2gpx:33:in `output_gpx': undefined method `recording_interval' for nil:NilClass (NoMethodError)
If one kind (e.g. cadence) of data is missing, all values are zeros for it, thus no need to to check for single values for export. If sometimes zero value is real data (e.g. temperature in winter) - it will not be skipped because we know that same array has also non-zero data.
|
Hi, Not sure you need any of this, now that you parse SAMPLES.BPB when SAMPLES.GZB is not present? |
|
Initially this pull request #49 seemed as direct solution for #47 but now seems just polishing.
Thus I still would like to see it merge though purpose is no longer #47 itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more fix for #47 :
polar_training2gpx:33:inoutput_gpx': undefined methodrecording_interval' for nil:NilClass (NoMethodError)This could happen if SAMPLES file not exist or has no data.