Force updateGrid in expectedFromGrid HybridNew.cc #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if using `--noUpdateGrid` with `--expectedFromGrid` and the grid file was not produced using the same value for expectedFromGrid, then the limit will be identical to the result without `--expectedFromGrid`. With this change, we now *force* an update if `--expectedFromGrid` option set. Usual workflow is to produce the grid (without this option) and then calculate expected results after, so this works with this workflow if user adds `--noUpdateGrid`
|
Added the needs work label since there could be a smarter way to do this, without having to resort to a full update at various points |
|
Note, have also added a warning about this in the docs : 21ad9b0#diff-e1cf5d8257ea3082032f066028c25c4e5134426b497d6f3f40042e955177759dR585-R587 |
… on quantileFrom gridfile
|
Slightly smarter now in that the update will only happen, even if user specifies Not bullet proof but for normal workflows, should catch most issues |
|
I think this one can be merged now, so if no objections, i'll do so soon |
nucleosynthesis
deleted the
nucleosynthesis-fix-noUpdateGrid-with-expectedFromGrid
branch
kcormi
pushed a commit
to kcormi/HiggsAnalysis-CombinedLimit
that referenced
this pull request
Jun 24, 2024
* Force updateGrid in expectedFromGrid HybridNew.cc if using `--noUpdateGrid` with `--expectedFromGrid` and the grid file was not produced using the same value for expectedFromGrid, then the limit will be identical to the result without `--expectedFromGrid`. With this change, we now *force* an update if `--expectedFromGrid` option set. Usual workflow is to produce the grid (without this option) and then calculate expected results after, so this works with this workflow if user adds `--noUpdateGrid` * Check if really necessary to update grid with expectedFromGrid based on quantileFrom gridfile --------- Co-authored-by: Nick Wardle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if using
--noUpdateGridwith--expectedFromGridand the grid file was not produced using the same value for expectedFromGrid, then the limit will be identical to the result without--expectedFromGrid.With this change, we now force an update if
--expectedFromGridoption set. Usual workflow is to produce the grid (without this option) and then calculate expected results after, so this works with this workflow if user adds--noUpdateGrid