Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in standalone compilation #950

Merged
merged 3 commits into from
May 21, 2024

Conversation

guitargeek
Copy link
Contributor

This fixes remaining problems with the standalone compilation.

@guitargeek
Copy link
Contributor Author

guitargeek commented May 13, 2024

Hi @anigamova ! Can this also be part of the v1.0 release? Or preferably just merged now. It's a harmless change, but important for compatibility.

This is needed for standalone compilation, and can be done everywhere
without breaking CMSSW compatibility (except for in `src/classes.h`).
This fixes compilation with more pedantinc compilers: even though the
`RandStartPtr` was declared as a friend class, it uses the
`MultiDimFit::GridType` in its public interface. This is not allowed.
@anigamova
Copy link
Collaborator

thanks @guitargeek! yes I think we can merge this

@anigamova anigamova merged commit 43e6579 into cms-analysis:main May 21, 2024
10 checks passed
@guitargeek guitargeek deleted the compiler_errors branch May 21, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants