Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow description to contributing.md #954

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Add workflow description to contributing.md #954

merged 2 commits into from
Apr 30, 2024

Conversation

anigamova
Copy link
Collaborator

No description provided.

@kcormi
Copy link
Collaborator

kcormi commented Apr 26, 2024

This is nice, thanks!

Could we perhaps switch the images to using the markdown format:

![alternative text](img path)

I think other html properties can be added with

![alternative text](img path){:property1=value1 :property2=value2}

syntax, but I haven't tried it, so we should check if it renders properly. It would just be nice if we keep things more markdown so that it is still more readable even when its not being rendered somewhere. But providing the alt-text even in the html could be fine if the markdown doesnt work well.

@nucleosynthesis are there other things/information about the Github actions we should add?

@nucleosynthesis
Copy link
Contributor

nucleosynthesis commented Apr 26, 2024 via email

@anigamova
Copy link
Collaborator Author

Unfortunately resizing does not work with markdown syntax, so I just removed these absolutely unnecessary images

@kcormi kcormi merged commit 80f8b79 into main Apr 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants