Ignore wrong contest submissions in ProxyService #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1142 +/- ##
==========================================
+ Coverage 63.56% 63.61% +0.04%
==========================================
Files 233 233
Lines 17117 17126 +9
==========================================
+ Hits 10881 10894 +13
+ Misses 6236 6232 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
andreyv
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Thanks, conceptually this looks good.
I think it is better placed in submission_scored()/submission_tokened():
_missing_operations()filters by contest id anyway- You can put the code together with the other checks and log a message
dataset_updated()can have its own meaningful message
Could you please update the PR accordingly?
|
Sure! I'll take a look again at this in few days, I'm pretty busy right now! |
edomora97
force-pushed
the
fix-ps-multicontest
branch
from
832781d
to
295b7f4
Compare
|
Sorry for the small delay, I've rebased on the current master and fixed the comments you left. Not sure why the CI doesn't work, but it seems quite unrelated. |
Merged
andreyv
requested changes
Dec 13, 2021
edomora97
force-pushed
the
fix-ps-multicontest
branch
from
babed7c
to
ee73339
Compare
When you are running cms with more than a contest (ie multicontest) ProxyService can be notified by ScoringService of new submissions of any contest, ignoring the `-c X` flag of PS. This will lead to `Inconsistent Data` errors in RWS due to submissions of the wrong contest (bad user, bad task, ...). This is especially bad because the wrong submission can be sent with other valid submissions, and RWS drop them all. The proposed fix just ignores those submissions from ProxyService since ScoringService has no way to know which contest PS is bound to.
Filter out the submissions from the wrong contest before rejecting them if they are hidden/unofficial. Add also some debug logging when it happens. This also adds the check in dataset_updated() since AWS may trigger the same kind of wrong RWS notifications.
andreyv
force-pushed
the
fix-ps-multicontest
branch
from
ee73339
to
326375e
Compare
|
Thanks, now the changes look good. Please adjust the code to 79 characters and add periods at the end of log messages. Also, you can print submission id with |
|
Done! Btw, is there an automated tool for formatting the code? |
|
Thanks, merging. Well, not currently, but one could be used in the future. |
andreyv
approved these changes
Dec 17, 2021
stefano-maggiolo
pushed a commit
to stefano-maggiolo/cms
that referenced
this pull request
Dec 21, 2021
* Ignore wrong contest submissions in ProxyService When you are running cms with more than a contest (ie multicontest) ProxyService can be notified by ScoringService of new submissions of any contest, ignoring the `-c X` flag of PS. This will lead to `Inconsistent Data` errors in RWS due to submissions of the wrong contest (bad user, bad task, ...). This is especially bad because the wrong submission can be sent with other valid submissions, and RWS drop them all. The proposed fix just ignores those submissions from ProxyService since ScoringService has no way to know which contest PS is bound to. * Move the contest_id checks in submission_scored/tokened * Move PS contest checks before submission validation Filter out the submissions from the wrong contest before rejecting them if they are hidden/unofficial. Add also some debug logging when it happens. This also adds the check in dataset_updated() since AWS may trigger the same kind of wrong RWS notifications. * Fix line lengths and message format
RezwanArefin01
pushed a commit
to RezwanArefin01/cms
that referenced
this pull request
Dec 27, 2021
* Ignore wrong contest submissions in ProxyService When you are running cms with more than a contest (ie multicontest) ProxyService can be notified by ScoringService of new submissions of any contest, ignoring the `-c X` flag of PS. This will lead to `Inconsistent Data` errors in RWS due to submissions of the wrong contest (bad user, bad task, ...). This is especially bad because the wrong submission can be sent with other valid submissions, and RWS drop them all. The proposed fix just ignores those submissions from ProxyService since ScoringService has no way to know which contest PS is bound to. * Move the contest_id checks in submission_scored/tokened * Move PS contest checks before submission validation Filter out the submissions from the wrong contest before rejecting them if they are hidden/unofficial. Add also some debug logging when it happens. This also adds the check in dataset_updated() since AWS may trigger the same kind of wrong RWS notifications. * Fix line lengths and message format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are running cms with more than a contest (ie multicontest) ProxyService can be notified by ScoringService of new submissions of any contest, ignoring the
-c Xflag of PS. This will lead toInconsistent Dataerrors in RWS due to submissions of the wrong contest (bad user, bad task, ...). This is especially bad because the wrong submission can be sent with other valid submissions, and RWS drop them all.The proposed fix just ignores those submissions from ProxyService since ScoringService has no way to know which contest PS is bound to.
Related to #1102 but less intrusive.
This change is