Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ephemeral services. #1302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

veluca93
Copy link
Collaborator

@veluca93 veluca93 commented Dec 6, 2024

Ephemeral services are services that are not fixed in the configuration file, but dynamically added as they connect. This is especially useful in a setup in which cmsWorker/cmsContestWebServer are scaled dynamically, as one might do when configuring CMS for running on cloud services.

@veluca93 veluca93 requested a review from wil93 December 6, 2024 10:29
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 71.15385% with 30 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@df9a5fa). Learn more about missing BASE report.
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cms/conf.py 60.41% 19 Missing ⚠️
cms/util.py 65.00% 7 Missing ⚠️
cms/service/workerpool.py 76.92% 3 Missing ⚠️
cms/server/contest/server.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage        ?   68.66%           
=======================================
  Files           ?      330           
  Lines           ?    26409           
  Branches        ?        0           
=======================================
  Hits            ?    18133           
  Misses          ?     8276           
  Partials        ?        0           
Flag Coverage Δ
functionaltests 46.76% <58.58%> (?)
unittests 55.99% <48.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veluca93 veluca93 force-pushed the ephemeral-services branch 2 times, most recently from ea1c381 to cb157a2 Compare December 6, 2024 20:09
cms/conf.py Outdated Show resolved Hide resolved
Ephemeral services are services that are not fixed in the configuration
file, but dynamically added as they connect. This is especially useful
in a setup in which cmsWorker/cmsContestWebServer are scaled
dynamically, as one might do when configuring CMS for running on cloud
services.
Copy link
Member

@wil93 wil93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest expanding the documentation to add some information about this new kind of service.

@wil93 wil93 changed the base branch from master to main December 26, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants